[Docs Site] Add hashes back into entrypoint filenames, disable hoisting. #17429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KianNH
requested review from
a team,
GregBrimble,
WalshyDev,
haleycode,
kristianfreeman,
marciocloudflare,
maxvp and
pedrosousa
as code owners
github-actions
bot
assigned
GregBrimble,
haleycode,
kristianfreeman,
marciocloudflare,
maxvp,
pedrosousa and
WalshyDev
WalshyDev
approved these changes
Oct 9, 2024
penalosa
approved these changes
Oct 9, 2024
Deploying cloudflare-docs with
|
| Latest commit: |
98a7ac6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4bfa2f7a.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://kian-pcx-13865.cloudflare-docs-7ou.pages.dev |
Member
Author
|
Tested that footnotes/Mermaid (loaded in |
elithrar
pushed a commit
that referenced
this pull request
Oct 15, 2024
maheshwarip
pushed a commit
that referenced
this pull request
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add hashes back into entrypoint filenames, disable hoisting.
The
hoisted.jsfile is present in the<head>of every page built, but the content hashes were changing as the scripts imports were identical but the ordering was not.directRenderScriptwill be the default in Astro 5 and removes the need for hoisting in the first place, so we're happy to enable it now.